Page MenuHomeElementl
Differential D8896

consolidate event type to run status lookup
ClosedPublic
Actions

Authored by • yuhan on Jul 14 2021, 5:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 14, 12:08 PM
Unknown Object (File)
Tue, Mar 14, 12:08 PM
Unknown Object (File)
Tue, Mar 14, 12:08 PM
Unknown Object (File)
Fri, Mar 10, 1:18 PM
Unknown Object (File)
Thu, Mar 9, 12:29 AM
Unknown Object (File)
Fri, Mar 3, 10:12 PM
Unknown Object (File)
Sun, Feb 26, 5:02 PM
Unknown Object (File)
Fri, Feb 24, 7:51 AM
View All 64 Files
Subscribers
None

Details

Reviewers
• prha
alangenfeld
Commits
R1:19f525d6f7be: consolidate event type to run status lookup
Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• yuhan created this revision.Jul 14 2021, 5:52 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2021, 6:34 PM
Harbormaster failed remote builds in B33709: Diff 41626!
• yuhan requested review of this revision.Jul 14 2021, 7:51 PM
• yuhan added a child revision: D8900: RunStatusSensorDefinition and @run_status_sensor.Jul 14 2021, 7:56 PM
• prha accepted this revision.Jul 14 2021, 10:48 PM
• prha added inline comments.
python_modules/dagster/dagster/core/events/__init__.py
153–161

consider adding this as a static method on PipelineRunStatus? e.g. from_pipeline_event

163

we don't use this anywhere, right?

This revision is now accepted and ready to land.Jul 14 2021, 10:48 PM
• yuhan added inline comments.Jul 14 2021, 11:14 PM
python_modules/dagster/dagster/core/events/__init__.py
163

will use it in https://dagster.phacility.com/D8900
but it depends on the api decision over there

This revision was landed with ongoing or failed builds.Jul 22 2021, 5:29 PM
Closed by commit R1:19f525d6f7be: consolidate event type to run status lookup (authored by • yuhan). · Explain Why
This revision was automatically updated to reflect the committed changes.
• yuhan added a commit: R1:19f525d6f7be: consolidate event type to run status lookup.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
events/
14 lines
storage/
runs/
26 lines
18 lines

Diff 42094

View Options

python_modules/dagster/dagster/core/events/__init__.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/runs/in_memory.py

Loading...
View Options

python_modules/dagster/dagster/core/storage/runs/sql_run_storage.py

Loading...