Page MenuHomeElementl

GraphDefinition.solid_dict -> node_dict
ClosedPublic

Authored by alangenfeld on Jul 14 2021, 5:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 25, 3:53 PM
Unknown Object (File)
Wed, Jun 22, 3:23 PM
Unknown Object (File)
Tue, Jun 21, 4:19 PM
Unknown Object (File)
Sun, Jun 19, 2:35 PM
Unknown Object (File)
Wed, Jun 15, 6:24 PM
Unknown Object (File)
Mon, Jun 13, 5:13 PM
Unknown Object (File)
Mon, Jun 13, 3:23 PM
Unknown Object (File)
Sat, Jun 4, 2:50 AM
Subscribers
None

Details

Summary

Start renaming solid methods that return Node to node

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2021, 5:51 PM
Harbormaster failed remote builds in B33705: Diff 41619!

Macro thumbsup:

python_modules/dagster/dagster/core/definitions/graph.py
183

nit: any reason to keep the internal attribute as _solid_dict? no need to do it in this diff tho

This revision is now accepted and ready to land.Jul 14 2021, 9:40 PM
python_modules/dagster/dagster/core/definitions/graph.py
183

good call

This revision was automatically updated to reflect the committed changes.