Page MenuHomeElementl
Differential D8864

asset catalog perf: make use of tags column if migrated
ClosedPublic
Actions

Authored by prha on Jul 13 2021, 6:38 PM.

Details

Reviewers
sandyryza
owen
Commits
R1:f6c6372344ce: asset catalog perf: make use of tags column if migrated
Summary

Noticed that the schema / data migration wasn't improving wall-clock
load time for the asset catalog. Saw that the graphql implementation was
bypassing the event_log_storage get_asset_tags call

Before:

Screen Shot 2021-07-13 at 12.34.16 PM.png (2×3 px, 1 MB)

After:
Screen Shot 2021-07-13 at 12.35.02 PM.png (2×3 px, 1 MB)

Test Plan

ran py-spy against speedscope, bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha created this revision.Jul 13 2021, 6:38 PM
prha edited the summary of this revision. (Show Details)Jul 13 2021, 6:39 PM
prha added a comment.Jul 13 2021, 6:53 PM

Should improve asset query load time by a factor of 3 if migrated and constant if not migrated

Harbormaster completed remote builds in B33641: Diff 41538.Jul 13 2021, 7:03 PM
prha requested review of this revision.Jul 13 2021, 7:03 PM
owen accepted this revision.Jul 13 2021, 7:26 PM
This revision is now accepted and ready to land.Jul 13 2021, 7:26 PM
Closed by commit R1:f6c6372344ce: asset catalog perf: make use of tags column if migrated (authored by prha). · Explain WhyJul 13 2021, 7:31 PM
This revision was automatically updated to reflect the committed changes.
prha added a commit: R1:f6c6372344ce: asset catalog perf: make use of tags column if migrated.

Revision Contents
Changeset List

PathSize
python_modules/
dagster-graphql/
dagster_graphql/
schema/
pipelines/
9 lines

Diff 41543

View Options

python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py

Loading...