Page MenuHomeElementl

asset catalog perf: make use of tags column if migrated
ClosedPublic

Authored by prha on Jul 13 2021, 6:38 PM.

Details

Summary

Noticed that the schema / data migration wasn't improving wall-clock
load time for the asset catalog. Saw that the graphql implementation was
bypassing the event_log_storage get_asset_tags call

Before:

Screen Shot 2021-07-13 at 12.34.16 PM.png (2×3 px, 1 MB)

After:
Screen Shot 2021-07-13 at 12.35.02 PM.png (2×3 px, 1 MB)

Test Plan

ran py-spy against speedscope, bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Should improve asset query load time by a factor of 3 if migrated and constant if not migrated

prha requested review of this revision.Jul 13 2021, 7:03 PM
This revision is now accepted and ready to land.Jul 13 2021, 7:26 PM