Page MenuHomeElementl

have AzureComputeLogManager implement CapturedLogManager interface
Needs ReviewPublic

Authored by prha on Jul 12 2021, 9:59 PM.

Details

Summary

depends on D8385, D8840

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

python_modules/libraries/dagster-azure/dagster_azure/blob/compute_log_manager.py
73–75

definitely odd pattern

python_modules/libraries/dagster-azure/dagster_azure_tests/blob_tests/test_compute_log_manager.py
147–149

can you not just mock out the free function in the module or does it break?

python_modules/libraries/dagster-azure/dagster_azure_tests/blob_tests/test_compute_log_manager.py
147–149

Unfortunately, the scope of the mocking function ends after the log manager is created, not when it is applied in the capture_logs contextmanager.