Page MenuHomeElementl

[docs] Dagster K8s deployment guide corrections - GH Issue #4234
ClosedPublic

Authored by sidkmenon on Jul 12 2021, 9:54 PM.

Details

Summary

As raised in Issue 4234, the Helm deployment guides were a bit lacking. The very kind @mcallaway offered some great tips about improving it, so I incorporated those into the docs page.

Docs link at (incoming, may not have built yet): https://dagster-git-sid-issue-4234-elementl.vercel.app/master/deployment/guides/kubernetes/deploying-with-helm

Co-authored-by: Matt Callaway @mcallaway

Test Plan

Went through deployment guide, produced a successful run over S3.

Diff Detail

Repository
R1 dagster
Branch
sid/issue-4234 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

sidkmenon edited the summary of this revision. (Show Details)
rexledesma added inline comments.
docs/content/deployment/guides/kubernetes/deploying-with-helm.mdx
184

I think we should mark this as optional, since this looks like a lot of setup

186
259–269

similarly, there should be two yaml blocks present - one for deploying without setting up AWS (the previous yaml block), and another for deploying with AWS (your current one)

356

feels odd to include that preface

384–410

❤️

This revision now requires changes to proceed.Jul 13 2021, 2:01 PM
sidkmenon marked 5 inline comments as done.

Updating to address @rexledesma's comments

docs/content/deployment/guides/kubernetes/deploying-with-helm.mdx
184

So you need to set up either S3 or minio for the default configuration to work - I'll mark it as optional, but I'll add a note here & below clarifying that.

259–269

So in this case, because of the way I set up the secrets, both YAML blocks would be identical - i'll add a note that this works with either real S3 or minio.

356

So the reason for the preface was the use of host.docker.internal which I think works out-of-the-box only on MacOS (and maybe Windows) - you need to build the docker images differently and do some docker networking shenanigans on Linux. Do you still think I should remove it? Fine either way!

Good stuff

docs/content/deployment/guides/kubernetes/deploying-with-helm.mdx
401

could note, there's also a button in dagit for this which is probably easier

This revision was not accepted when it landed; it landed in state Needs Review.Jul 15 2021, 5:47 PM
This revision was automatically updated to reflect the committed changes.