Page MenuHomeElementl
Differential D8833

make sure pipeline_failure_sensor is under test
ClosedPublic
Actions

Authored by prha on Jul 12 2021, 8:35 PM.

Details

Reviewers
yuhan
alangenfeld
Commits
R1:d9f5cafa1f0c: make sure pipeline_failure_sensor is under test
Summary

Would have caught the get_event_record callsite error sooner. :(

Test Plan

ran unittest

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha created this revision.Jul 12 2021, 8:35 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2021, 8:58 PM
Harbormaster failed remote builds in B33577: Diff 41449!
prha updated this revision to Diff 41451.Jul 12 2021, 8:58 PM

rebase

Harbormaster completed remote builds in B33578: Diff 41451.Jul 12 2021, 9:42 PM
prha requested review of this revision.Jul 12 2021, 9:42 PM
yuhan accepted this revision.Jul 13 2021, 6:18 PM

thankyou

This revision is now accepted and ready to land.Jul 13 2021, 6:18 PM
Closed by commit R1:d9f5cafa1f0c: make sure pipeline_failure_sensor is under test (authored by prha). · Explain WhyJul 13 2021, 6:21 PM
This revision was automatically updated to reflect the committed changes.
prha added a commit: R1:d9f5cafa1f0c: make sure pipeline_failure_sensor is under test.

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
definitions/
19 lines
7 lines
dagster_tests/
daemon_tests/
92 lines

Diff 41533

View Options

python_modules/dagster/dagster/core/definitions/pipeline_sensor.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/sensor.py

Loading...
View Options

python_modules/dagster/dagster_tests/daemon_tests/test_sensor_run.py

Loading...