pin dbt for test
ClosedPublic
Actions

Authored by • prha on Jul 12 2021, 8:11 PM.

Details

Reviewers

• sandyryza
• owen

Commits

R1:fdbcecb76c5d: pin dbt for test

Summary

We should unpin once we determine the underlying incompatibility

Test Plan

Diff Detail

Repository

R1 dagster

Branch

prha/dbt_pin

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• prha created this revision.Jul 12 2021, 8:11 PM

• prha edited the summary of this revision. (Show Details)Jul 12 2021, 8:23 PM

• prha added reviewers: • sandyryza, • owen.

Harbormaster completed remote builds in B33573: Diff 41444.Jul 12 2021, 8:38 PM

• prha requested review of this revision.Jul 12 2021, 8:38 PM

one other option that might work would be to remove the PROFILES_DIR configuration (https://sourcegraph.com/github.com/dagster-io/dagster/-/blob/examples/dbt_example/dbt_example/solids.py?L11). It seems like the value that it's set to is the default value for dbt, so it doesn't really do anything, and might be having some weird interaction with the update. The changelog for dbt mentions some changes to how they interpret the profiles-dir path (relative to the project-dir path vs absolute) that I wouldn't think would impact us, but it seems possible that this would be a buggy side effect

• owen accepted this revision.Jul 12 2021, 8:39 PM

This revision is now accepted and ready to land.Jul 12 2021, 8:39 PM

gonna just land this to unblock our test suite.

Follow up issue is here: https://github.com/dagster-io/dagster/issues/4351

Closed by commit R1:fdbcecb76c5d: pin dbt for test (authored by • prha). · Explain WhyJul 12 2021, 8:47 PM

This revision was automatically updated to reflect the committed changes.

• prha added a commit: R1:fdbcecb76c5d: pin dbt for test.

• prha added a reverting change: D8839: Revert "pin dbt for test", try removing default dbt profile dir.Jul 12 2021, 9:44 PM

• prha added a reverting change: R1:b14acdec328a: Revert "pin dbt for test", try removing default dbt profile dir.Jul 12 2021, 10:34 PM