Page MenuHomeElementl

pin dbt for test
ClosedPublic

Authored by prha on Jul 12 2021, 8:11 PM.

Details

Summary

We should unpin once we determine the underlying incompatibility

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha added reviewers: sandyryza, owen.
prha requested review of this revision.Jul 12 2021, 8:38 PM

one other option that might work would be to remove the PROFILES_DIR configuration (https://sourcegraph.com/github.com/dagster-io/dagster/-/blob/examples/dbt_example/dbt_example/solids.py?L11). It seems like the value that it's set to is the default value for dbt, so it doesn't really do anything, and might be having some weird interaction with the update. The changelog for dbt mentions some changes to how they interpret the profiles-dir path (relative to the project-dir path vs absolute) that I wouldn't think would impact us, but it seems possible that this would be a buggy side effect

This revision is now accepted and ready to land.Jul 12 2021, 8:39 PM

gonna just land this to unblock our test suite.

Follow up issue is here: https://github.com/dagster-io/dagster/issues/4351

This revision was automatically updated to reflect the committed changes.