Page MenuHomeElementl

unbreak dagit read-only mode
ClosedPublic

Authored by dgibson on Jul 12 2021, 1:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jul 23, 1:15 AM
Unknown Object (File)
Wed, Jul 20, 5:36 PM
Unknown Object (File)
Wed, Jul 20, 1:20 AM
Unknown Object (File)
Sun, Jul 17, 6:21 PM
Unknown Object (File)
Fri, Jul 15, 9:22 AM
Unknown Object (File)
Jul 12 2022, 6:01 AM
Unknown Object (File)
Jul 12 2022, 6:01 AM
Unknown Object (File)
Jul 12 2022, 6:01 AM
Subscribers
None

Details

Summary

While testing some read-only related changes it became clear that a bad refactor caused the read_only param to the dagit CLI to get thrown out :( This diff threads it through correctly.

Test Plan

BK, load dagit with --read-only and verify you can't launch pipelines

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Jul 12 2021, 3:44 PM
This revision was landed with ongoing or failed builds.Jul 12 2021, 3:54 PM
This revision was automatically updated to reflect the committed changes.

this behavior should be under test, something in python_modules/dagit/dagit_tests/test_app.py maybe