Page MenuHomeElementl
Differential D8811

unbreak dagit read-only mode
ClosedPublic
Actions

Authored by • dgibson on Jul 12 2021, 1:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 10, 9:44 PM
Unknown Object (File)
Mon, Mar 6, 1:22 AM
Unknown Object (File)
Feb 21 2023, 6:50 PM
Unknown Object (File)
Feb 12 2023, 3:53 AM
Unknown Object (File)
Feb 1 2023, 8:05 PM
Unknown Object (File)
Jan 31 2023, 5:19 AM
Unknown Object (File)
Jan 23 2023, 8:07 PM
Unknown Object (File)
Jan 21 2023, 2:40 PM
View All 58 Files
Subscribers
None

Details

Reviewers
alangenfeld
• johann
• jordansanders
• rexledesma
Commits
R1:b0d818fa4c26: unbreak dagit read-only mode
Summary

While testing some read-only related changes it became clear that a bad refactor caused the read_only param to the dagit CLI to get thrown out :( This diff threads it through correctly.

Test Plan

BK, load dagit with --read-only and verify you can't launch pipelines

Diff Detail

Repository
R1 dagster
Branch
rmreadonly3
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• dgibson created this revision.Jul 12 2021, 1:03 PM
• dgibson published this revision for review.Jul 12 2021, 1:21 PM
Harbormaster failed remote builds in B33524: Diff 41369!Jul 12 2021, 1:46 PM
• rexledesma accepted this revision.Jul 12 2021, 3:44 PM
This revision is now accepted and ready to land.Jul 12 2021, 3:44 PM
This revision was landed with ongoing or failed builds.Jul 12 2021, 3:54 PM
Closed by commit R1:b0d818fa4c26: unbreak dagit read-only mode (authored by • dgibson). · Explain Why
This revision was automatically updated to reflect the committed changes.
• dgibson added a commit: R1:b0d818fa4c26: unbreak dagit read-only mode.
alangenfeld added a comment.Jul 12 2021, 4:57 PM

this behavior should be under test, something in python_modules/dagit/dagit_tests/test_app.py maybe

Revision Contents
Changeset List

PathSize
examples/
docs_snippets/
docs_snippets_tests/
intro_tutorial_tests/
2 lines
python_modules/
dagit/
dagit/
2 lines
9 lines
dagit_tests/
1 line
dagster-graphql/
dagster_graphql/
2 lines
dagster/
dagster/
cli/
workspace/
10 lines
libraries/
dagster-dask/
dagster_dask_tests/
1 line

Diff 41369

View Options

examples/docs_snippets/docs_snippets_tests/intro_tutorial_tests/test_cli_invocations.py

Loading...
View Options

python_modules/dagit/dagit/app.py

Loading...
View Options

python_modules/dagit/dagit/cli.py

Loading...
View Options

python_modules/dagit/dagit_tests/test_smoke.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/cli.py

Loading...
View Options

python_modules/dagster/dagster/cli/workspace/cli_target.py

Loading...
View Options

python_modules/libraries/dagster-dask/dagster_dask_tests/test_graphql.py

Loading...