Page MenuHomeElementl

unbreak dagit read-only mode
ClosedPublic

Authored by dgibson on Jul 12 2021, 1:03 PM.

Details

Summary

While testing some read-only related changes it became clear that a bad refactor caused the read_only param to the dagit CLI to get thrown out :( This diff threads it through correctly.

Test Plan

BK, load dagit with --read-only and verify you can't launch pipelines

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dgibson published this revision for review.Jul 12 2021, 1:21 PM
This revision is now accepted and ready to land.Jul 12 2021, 3:44 PM
This revision was landed with ongoing or failed builds.Jul 12 2021, 3:54 PM
This revision was automatically updated to reflect the committed changes.

this behavior should be under test, something in python_modules/dagit/dagit_tests/test_app.py maybe