Page MenuHomeElementl
Differential D8810

[dag-star] graphql websocket endpoint
ClosedPublic
Actions

Authored by alangenfeld on Jul 9 2021, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 16, 3:41 PM
Unknown Object (File)
Mon, Mar 13, 10:49 AM
Unknown Object (File)
Fri, Mar 10, 3:58 PM
Unknown Object (File)
Feb 15 2023, 1:58 PM
Unknown Object (File)
Feb 14 2023, 11:59 PM
Unknown Object (File)
Feb 14 2023, 4:14 PM
Unknown Object (File)
Feb 13 2023, 2:47 AM
Unknown Object (File)
Feb 13 2023, 2:39 AM
View All Files
Subscribers
None

Details

Reviewers
• prha
• max
• dgibson
Commits
R1:8de70acb42bc: [dag-star] graphql websocket endpoint
Test Plan

added test

Diff Detail

Repository
R1 dagster
Branch
star (branched from master)
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningpython_modules/dagit/dagit_tests/starlette/test_app.py:1W0611Unused Import
Unit
No Test Coverage

Event Timeline

alangenfeld created this revision.Jul 9 2021, 9:52 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 9 2021, 10:36 PM
Harbormaster failed remote builds in B33516: Diff 41359!
alangenfeld updated this revision to Diff 41462.Jul 12 2021, 9:40 PM

rebase

alangenfeld updated this revision to Diff 41463.Jul 12 2021, 9:41 PM

lint

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2021, 10:22 PM
Harbormaster failed remote builds in B33588: Diff 41463!
Harbormaster failed remote builds in B33587: Diff 41462!
alangenfeld added a parent revision: D8808: [dag-star] graphql endpoint.Jul 13 2021, 4:57 PM
alangenfeld updated this revision to Diff 41524.Jul 13 2021, 5:37 PM

3.6 support

alangenfeld edited the test plan for this revision. (Show Details)Jul 13 2021, 5:38 PM
alangenfeld added reviewers: • prha, • max.
alangenfeld added a child revision: D8846: [dag-star] download debug file.
Harbormaster completed remote builds in B33630: Diff 41524.Jul 13 2021, 6:02 PM
alangenfeld requested review of this revision.Jul 13 2021, 6:02 PM
• prha added inline comments.Jul 13 2021, 6:50 PM
python_modules/dagit/dagit/starlette.py
146

nit: typo

147

nit: typo

280

I always get confused with this rx stuff... Should this also have on_error and on_completed?

• max added inline comments.Jul 21 2021, 11:30 PM
python_modules/dagit/dagit/starlette.py
43

maybe consider an enum

211

[1] should this log?

224

[1]

276

is there any more color on this

python_modules/dagit/dagit_tests/starlette/test_app.py
120

might be nice to have the test explicitly check that the subscription is cleaned up (though might need to restructure how the closures work in order to make those assertions)

alangenfeld added inline comments.Jul 23 2021, 5:24 PM
python_modules/dagit/dagit/starlette.py
280

I couldn't coax any difference in behavior out in my local messing around when setting those

alangenfeld updated this revision to Diff 42220.Jul 23 2021, 6:21 PM

rebase, review feedback

Harbormaster completed remote builds in B34155: Diff 42220.Jul 23 2021, 7:26 PM
alangenfeld added a reviewer: • dgibson.Jul 26 2021, 8:49 PM
• prha accepted this revision.Jul 27 2021, 3:19 PM
This revision is now accepted and ready to land.Jul 27 2021, 3:19 PM
Closed by commit R1:8de70acb42bc: [dag-star] graphql websocket endpoint (authored by alangenfeld). · Explain WhyJul 27 2021, 9:14 PM
This revision was automatically updated to reflect the committed changes.
alangenfeld added a commit: R1:8de70acb42bc: [dag-star] graphql websocket endpoint.

Revision Contents
Changeset List

PathSize
python_modules/
dagit/
dagit/
176 lines
dagit_tests/
starlette/
9 lines
69 lines

Diff 41462

View Options

python_modules/dagit/dagit/starlette.py

Loading...
View Options

python_modules/dagit/dagit_tests/starlette/conftest.py

Loading...
View Options

python_modules/dagit/dagit_tests/starlette/test_app.py

Loading...