Page MenuHomeElementl

[dag-star] graphql websocket endpoint
ClosedPublic

Authored by alangenfeld on Jul 9 2021, 9:52 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 16, 3:41 PM
Unknown Object (File)
Mon, Mar 13, 10:49 AM
Unknown Object (File)
Fri, Mar 10, 3:58 PM
Unknown Object (File)
Feb 15 2023, 1:58 PM
Unknown Object (File)
Feb 14 2023, 11:59 PM
Unknown Object (File)
Feb 14 2023, 4:14 PM
Unknown Object (File)
Feb 13 2023, 2:47 AM
Unknown Object (File)
Feb 13 2023, 2:39 AM
Subscribers
None

Diff Detail

Repository
R1 dagster
Branch
star (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 9 2021, 10:36 PM
Harbormaster failed remote builds in B33516: Diff 41359!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2021, 10:22 PM
Harbormaster failed remote builds in B33588: Diff 41463!
Harbormaster failed remote builds in B33587: Diff 41462!
python_modules/dagit/dagit/starlette.py
145

nit: typo

146

nit: typo

279

I always get confused with this rx stuff... Should this also have on_error and on_completed?

python_modules/dagit/dagit/starlette.py
42

maybe consider an enum

210

[1] should this log?

223

[1]

275

is there any more color on this

python_modules/dagit/dagit_tests/starlette/test_app.py
119 ↗(On Diff #41524)

might be nice to have the test explicitly check that the subscription is cleaned up (though might need to restructure how the closures work in order to make those assertions)

python_modules/dagit/dagit/starlette.py
279

I couldn't coax any difference in behavior out in my local messing around when setting those

This revision is now accepted and ready to land.Jul 27 2021, 3:19 PM
This revision was automatically updated to reflect the committed changes.