Page MenuHomeElementl

[dag-star] graphql websocket endpoint
ClosedPublic

Authored by alangenfeld on Jul 9 2021, 9:52 PM.

Details

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 9 2021, 10:36 PM
Harbormaster failed remote builds in B33516: Diff 41359!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 12 2021, 10:22 PM
Harbormaster failed remote builds in B33588: Diff 41463!
Harbormaster failed remote builds in B33587: Diff 41462!
python_modules/dagit/dagit/starlette.py
152

nit: typo

153

nit: typo

286

I always get confused with this rx stuff... Should this also have on_error and on_completed?

python_modules/dagit/dagit/starlette.py
45

maybe consider an enum

217

[1] should this log?

230

[1]

282

is there any more color on this

python_modules/dagit/dagit_tests/starlette/test_app.py
114

might be nice to have the test explicitly check that the subscription is cleaned up (though might need to restructure how the closures work in order to make those assertions)

python_modules/dagit/dagit/starlette.py
286

I couldn't coax any difference in behavior out in my local messing around when setting those

This revision is now accepted and ready to land.Jul 27 2021, 3:19 PM
This revision was automatically updated to reflect the committed changes.