Page MenuHomeElementl

[dag-star] index html and static resources
ClosedPublic

Authored by alangenfeld on Jul 9 2021, 8:55 PM.
Tags
None
Referenced Files
F2439257: D8809.id42302.diff
Tue, Aug 16, 7:29 PM
F2439256: D8809.id.diff
Tue, Aug 16, 7:29 PM
Unknown Object (File)
Mon, Aug 15, 8:06 AM
Unknown Object (File)
Fri, Aug 12, 11:52 AM
Unknown Object (File)
Tue, Aug 2, 4:30 PM
Unknown Object (File)
Jul 15 2022, 3:18 AM
Unknown Object (File)
Jul 15 2022, 3:18 AM
Unknown Object (File)
Jul 15 2022, 3:18 AM
Subscribers
None

Details

Summary

Add handlers to serve index.html and all the static resources

depends on D8807

Test Plan

Manual:
launch with uvicorn dagit.starlette:default_app --ws websockets --port 3333
vist localhost:3333/ verify dagit loads, server does not show errors for static resource requests

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 9 2021, 9:17 PM
Harbormaster failed remote builds in B33513: Diff 41355!
alangenfeld edited the test plan for this revision. (Show Details)
prha added inline comments.
python_modules/dagit/dagit/starlette.py
86–104

should we create placeholders for endpoints we haven't implemented yet (e.g. notebooks, download urls), or should we just do a checklist for cutting over?

This revision is now accepted and ready to land.Jul 12 2021, 5:19 PM
python_modules/dagit/dagit/starlette.py
86–104

whats your take? I don't have a real preference