[dag-star] index html and static resources
ClosedPublic
Actions

Authored by alangenfeld on Jul 9 2021, 8:55 PM.

Details

Reviewers

• prha
• max
• bengotow
• dish

Commits

R1:9cc482ca6ebd: [dag-star] index html and static resources

Summary

Add handlers to serve index.html and all the static resources

depends on D8807

Test Plan

Manual:
launch with uvicorn dagit.starlette:default_app --ws websockets --port 3333
vist localhost:3333/ verify dagit loads, server does not show errors for static resource requests

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

alangenfeld created this revision.Jul 9 2021, 8:55 PM

alangenfeld added reviewers: • bengotow, • dish.Jul 9 2021, 9:04 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 9 2021, 9:17 PM

Harbormaster failed remote builds in B33513: Diff 41355!

rebaes

alangenfeld edited the summary of this revision. (Show Details)Jul 9 2021, 10:20 PM

alangenfeld edited the test plan for this revision. (Show Details)

alangenfeld added a parent revision: D8807: [dag-star] initial starlette app for dagit.

alangenfeld removed a parent revision: D8808: [dag-star] graphql endpoint.

alangenfeld added a child revision: D8808: [dag-star] graphql endpoint.Jul 9 2021, 10:23 PM

Harbormaster completed remote builds in B33517: Diff 41360.Jul 9 2021, 10:45 PM

alangenfeld requested review of this revision.Jul 9 2021, 10:45 PM

• prha accepted this revision.Jul 12 2021, 5:19 PM

• prha added inline comments.

python_modules/dagit/dagit/starlette.py
86–104	should we create placeholders for endpoints we haven't implemented yet (e.g. notebooks, download urls), or should we just do a checklist for cutting over?

This revision is now accepted and ready to land.Jul 12 2021, 5:19 PM

alangenfeld added inline comments.Jul 12 2021, 5:23 PM