adds the http graphql endpoint, websockets to follow
depends on D8809
Details
Details
- Reviewers
• prha • max - Commits
- R1:835fafac3195: [dag-star] graphql endpoint
added tests
load graphql playground, ensure it works
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| python_modules/dagit/dagit/starlette.py | ||
|---|---|---|
| 53–55 | lol Another significant change with this release is the deprecation of built-in GraphQL support. | |
| 102–108 | wonder if it'd be useful to have some sort of flag to turn on/off the threaded behavior, especially for debugging | |
| python_modules/dagit/dagit_tests/starlette/test_app.py | ||
| 31 | maybe these tests should be common across starlette and flask? | |
| python_modules/dagit/dagit/starlette.py | ||
|---|---|---|
| 53–55 | yeah there are other graphql frameworks that offer ASGI handlers/endpoints, but we can't really use them directly without conflicting with our existing deps from the graphql-ws frankenstein set up so i've had to end up forking instead of dealing with conflicting dep mgmt. We should be able to switch to something like strawberry-graphql after we shed the graphql-ws stuff | |