Page MenuHomeElementl

[dag-star] initial starlette app for dagit
ClosedPublic

Authored by alangenfeld on Jul 9 2021, 7:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 11, 4:05 AM
Unknown Object (File)
May 8 2023, 9:43 PM
Unknown Object (File)
May 6 2023, 7:31 PM
Unknown Object (File)
Apr 14 2023, 8:04 AM
Unknown Object (File)
Apr 12 2023, 11:29 PM
Unknown Object (File)
Apr 7 2023, 6:57 AM
Unknown Object (File)
Mar 22 2023, 10:05 AM
Unknown Object (File)
Mar 11 2023, 6:52 PM
Subscribers
None

Details

Summary

Our existing Flask + graphql-ws + gevent implementation of dagit has a number of issues

I did an exploration of starlette in D8040 which was promising. I believe we can move to this modern ASGI framework which gives us greater control and testability. This will be key in both resolving current issues and evolving dagit more effectively moving forward.

This first diff gets basic scaffolding in place and the dagit_info endpoint. Subsequent diffs will add other endpoints until we have parity with the flask app. After some further experimentation with it once working we can figure out a cut over strategy.

Test Plan

added test

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 9 2021, 8:01 PM
Harbormaster failed remote builds in B33509: Diff 41350!
This revision is now accepted and ready to land.Jul 12 2021, 5:13 PM