Page MenuHomeElementl
Differential D8797

refactor(helm): remove enabled flag in run coordinator
AcceptedPublic
Actions

Authored by • rexledesma on Jul 9 2021, 4:56 AM.
Tags
None
Referenced Files
Unknown Object (File)
May 5 2023, 1:25 AM
Unknown Object (File)
Apr 30 2023, 8:14 AM
Unknown Object (File)
Apr 9 2023, 5:24 AM
Unknown Object (File)
Mar 10 2023, 9:48 PM
Unknown Object (File)
Feb 17 2023, 8:11 AM
Unknown Object (File)
Feb 14 2023, 5:58 PM
Unknown Object (File)
Feb 8 2023, 10:46 AM
Unknown Object (File)
Feb 8 2023, 2:18 AM
View All 54 Files
Subscribers
None

Details

Reviewers
• johann
• sidkmenon
Summary

I forgot the DefaultRunCoordinator is a thing. Use that as an enum to remove the odd enabled toggle.

Test Plan

pytest
integration

Diff Detail

Repository
R1 dagster
Branch
rl/remove-enabled-run-coordinator (branched from master)
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• rexledesma created this revision.Jul 9 2021, 4:56 AM
Harbormaster completed remote builds in B33489: Diff 41324.Jul 9 2021, 5:22 AM
• rexledesma requested review of this revision.Jul 9 2021, 5:22 AM
• sidkmenon accepted this revision.Jul 9 2021, 3:00 PM

lgtm besides the comment

helm/dagster/values.yaml
757–758

presumably there are other reasons to want to use the queuedRunCoordinator?

This revision is now accepted and ready to land.Jul 9 2021, 3:00 PM
• rexledesma added inline comments.Jul 9 2021, 3:34 PM
helm/dagster/values.yaml
757–758

oops

• rexledesma edited the test plan for this revision. (Show Details)Jul 9 2021, 5:23 PM
• rexledesma updated this revision to Diff 41344.Jul 9 2021, 5:26 PM

up

Harbormaster completed remote builds in B33504: Diff 41344.Jul 9 2021, 5:52 PM

Revision Contents
Changeset List

PathSize
helm/
dagster/
schema/
schema/
charts/
dagster/
subschema/
2 lines
schema_tests/
44 lines
templates/
2 lines
17 lines
integration_tests/
python_modules/
dagster-k8s-test-infra/
dagster_k8s_test_infra/
5 lines

Diff 41344

View Options

helm/dagster/schema/schema/charts/dagster/subschema/daemon.py

Loading...
View Options

helm/dagster/schema/schema_tests/test_instance.py

Loading...
View Options

helm/dagster/templates/configmap-instance.yaml

Loading...
View Options

helm/dagster/values.schema.json

Loading...
View Options

helm/dagster/values.yaml

Loading...
View Options

integration_tests/python_modules/dagster-k8s-test-infra/dagster_k8s_test_infra/helm.py

Loading...