Page MenuHomeElementl
Differential D8765

[dagit] Crag: Fix Job browser titles
ClosedPublic
Actions

Authored by • dish on Jul 8 2021, 3:35 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Feb 1, 8:53 AM
Unknown Object (File)
Dec 22 2022, 4:15 AM
Unknown Object (File)
Dec 16 2022, 12:35 PM
Unknown Object (File)
Nov 24 2022, 3:11 AM
Unknown Object (File)
Nov 18 2022, 12:54 AM
Unknown Object (File)
Nov 18 2022, 12:54 AM
Unknown Object (File)
Nov 18 2022, 12:53 AM
Unknown Object (File)
Nov 18 2022, 12:53 AM
View All 47 Files
Subscribers
None

Details

Reviewers
• bengotow
• prha
• sandyryza
Commits
R1:1b00dcfd24be: [dagit] Crag: Fix Job browser titles
Summary

I noticed that we're still showing "Pipeline:" for most Job page tabs for crag-flagged users. Fix this to be "Job:", with the pipeline:mode tuple displayed.

Test Plan

Verify correct browser titles inside and outside flag.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dish created this revision.Jul 8 2021, 3:35 PM
Harbormaster completed remote builds in B33413: Diff 41215.Jul 8 2021, 3:43 PM
• dish requested review of this revision.Jul 8 2021, 3:43 PM
• bengotow accepted this revision.Jul 8 2021, 5:43 PM

Ahh good catch! I think I had too many tabs open to notice this one 🙈

This revision is now accepted and ready to land.Jul 8 2021, 5:43 PM
• dish updated this revision to Diff 41242.Jul 8 2021, 5:51 PM

Rebase

Harbormaster completed remote builds in B33428: Diff 41242.Jul 8 2021, 6:01 PM
Closed by commit R1:1b00dcfd24be: [dagit] Crag: Fix Job browser titles (authored by • dish). · Explain WhyJul 8 2021, 6:02 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:1b00dcfd24be: [dagit] Crag: Fix Job browser titles.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
execute/
9 lines
7 lines
partitions/
7 lines
pipelines/
4 lines
8 lines
20 lines

Diff 41245

View Options

js_modules/dagit/packages/core/src/execute/PipelineExecutionRoot.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/execute/PipelineExecutionSetupRoot.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/partitions/PipelinePartitionsRoot.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/pipelines/PipelineOverviewRoot.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/pipelines/PipelineRunsRoot.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/pipelines/useJobTitle.tsx

Loading...