Page MenuHomeElementl

[dagit] Crag: Don't show Partitions tab if none for Job
ClosedPublic

Authored by dish on Jul 8 2021, 3:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 7, 7:32 AM
Unknown Object (File)
Sun, Jan 22, 12:45 PM
Unknown Object (File)
Sun, Jan 15, 6:03 PM
Unknown Object (File)
Jan 6 2023, 9:03 PM
Unknown Object (File)
Jan 1 2023, 2:46 PM
Unknown Object (File)
Dec 22 2022, 8:40 PM
Unknown Object (File)
Dec 19 2022, 7:15 AM
Unknown Object (File)
Dec 7 2022, 10:24 AM
Subscribers
None

Details

Summary

For Jobs that do not have partitions, don't show the Partitions tab.

When determining whether to render the tab, find partition sets that share the current pipeline name (or job name) and, if flagged, also check the mode name in the URL. If there are any, show the tab.

Test Plan

In flag, view a job in Dagit. Verify that the Partitions tab appears when there is a pipeline name/mode match. Verify that it does not appear otherwise.

Outside flag, repeat, verify that the tab appears when there is a pipeline name match.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dish created this revision.

some instead of length check

bengotow added inline comments.
js_modules/dagit/packages/core/src/nav/PipelineNav.tsx
105

Looks good! Hopefully once we enable tuples for everyone we can simplify a few of these - I feel like we’ve needed to add this mode check in so many places and some of them are pretty subtle. In retrospect I wonder if we could have made a book or something :-/ hopefully this is the last of the sites though!

This revision is now accepted and ready to land.Jul 8 2021, 5:48 PM