ReadOnlyError => UnauthorizedError
ClosedPublic
Actions

Authored by • dgibson on Jul 8 2021, 3:22 PM.

Details

Reviewers

• dish
• jordansanders
• sashank
• max

Commits

R1:4feb90634804: ReadOnlyError => UnauthorizedError

Summary

Making this more generic allows us to use it in other permission failure contexts.

Test Plan

BK, view dagit in read-only mode

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dgibson created this revision.Jul 8 2021, 3:22 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 8 2021, 3:45 PM

Harbormaster failed remote builds in B33409: Diff 41211!

Harbormaster completed remote builds in B33419: Diff 41224.Jul 8 2021, 4:43 PM

• dgibson requested review of this revision.Jul 8 2021, 4:43 PM

• jordansanders accepted this revision.Jul 8 2021, 5:50 PM

This revision is now accepted and ready to land.Jul 8 2021, 5:50 PM

Harbormaster completed remote builds in B33521: Diff 41365.Jul 11 2021, 1:00 AM

Harbormaster completed remote builds in B33520: Diff 41364.Jul 11 2021, 1:08 AM

Closed by commit R1:4feb90634804: ReadOnlyError => UnauthorizedError (authored by • dgibson). · Explain WhyJul 12 2021, 2:49 PM

This revision was automatically updated to reflect the committed changes.

• dgibson added a commit: R1:4feb90634804: ReadOnlyError => UnauthorizedError.

Revision Contents
Changeset List

Path

Size

js_modules/

dagit/

packages/

core/

src/

app/

PythonErrorInfo.tsx

4 lines

types/

ReadOnlyErrorFragment.ts

	UnauthorizedErrorFragment.ts
	ReadOnlyErrorFragment.ts

assets/

types/

AssetWipeMutation.ts

graphql/

possibleTypes.generated.json

schema.graphql

30 lines

instance/

InstanceBackfills.tsx

4 lines

types/

CancelBackfill.ts

resumeBackfill.ts

nav/

ReloadRepositoryLocationButton.tsx

2 lines

types/

ReloadRepositoryLocationMutation.ts

partitions/

PartitionsBackfill.tsx

2 lines

types/

LaunchPartitionBackfill.ts

runs/

DeletionDialog.tsx

4 lines

RunUtils.tsx

4 lines

TerminationDialog.tsx

4 lines

types/

Delete.ts

LaunchPipelineExecution.ts

LaunchPipelineReexecution.ts

Terminate.ts

schedules/

types/

ReconcileSchedulerState.ts

sensors/

types/

SensorRootQuery.ts

StartSensor.ts

StopSensor.ts

workspace/

types/

ReloadWorkspaceMutation.ts

useReloadWorkspace.tsx

8 lines

python_modules/

dagster-graphql/

dagster_graphql/

implementation/

utils.py

4 lines

schema/

backfill.py

8 lines

errors.py

10 lines

roots/

mutation.py

14 lines

schedules/

__init__.py

8 lines

sensors.py

6 lines

dagster_graphql_tests/

graphql/

test_execute_pipeline.py

2 lines

test_permissions.py

2 lines

Diff 41375

View Options

js_modules/dagit/packages/core/src/app/PythonErrorInfo.tsx

View Options

js_modules/dagit/packages/core/src/app/types/ReadOnlyErrorFragment.ts

View Options

js_modules/dagit/packages/core/src/app/types/UnauthorizedErrorFragment.ts

View Options

js_modules/dagit/packages/core/src/assets/types/AssetWipeMutation.ts

View Options

js_modules/dagit/packages/core/src/graphql/possibleTypes.generated.json

View Options

js_modules/dagit/packages/core/src/graphql/schema.graphql

View Options

js_modules/dagit/packages/core/src/instance/InstanceBackfills.tsx

View Options

js_modules/dagit/packages/core/src/instance/types/CancelBackfill.ts

View Options

js_modules/dagit/packages/core/src/instance/types/resumeBackfill.ts

View Options

js_modules/dagit/packages/core/src/nav/ReloadRepositoryLocationButton.tsx

View Options

js_modules/dagit/packages/core/src/nav/types/ReloadRepositoryLocationMutation.ts

View Options

js_modules/dagit/packages/core/src/partitions/PartitionsBackfill.tsx

View Options

js_modules/dagit/packages/core/src/partitions/types/LaunchPartitionBackfill.ts

View Options

js_modules/dagit/packages/core/src/runs/DeletionDialog.tsx

View Options

js_modules/dagit/packages/core/src/runs/RunUtils.tsx

View Options

js_modules/dagit/packages/core/src/runs/TerminationDialog.tsx

View Options

js_modules/dagit/packages/core/src/runs/types/Delete.ts

View Options

js_modules/dagit/packages/core/src/runs/types/LaunchPipelineExecution.ts

View Options

js_modules/dagit/packages/core/src/runs/types/LaunchPipelineReexecution.ts

View Options

js_modules/dagit/packages/core/src/runs/types/Terminate.ts

View Options

js_modules/dagit/packages/core/src/schedules/types/ReconcileSchedulerState.ts

View Options

js_modules/dagit/packages/core/src/sensors/types/SensorRootQuery.ts

View Options

js_modules/dagit/packages/core/src/sensors/types/StartSensor.ts

View Options

js_modules/dagit/packages/core/src/sensors/types/StopSensor.ts

View Options

js_modules/dagit/packages/core/src/workspace/types/ReloadWorkspaceMutation.ts

View Options

js_modules/dagit/packages/core/src/workspace/useReloadWorkspace.tsx

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/utils.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/backfill.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/errors.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/roots/mutation.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/schedules/init.py

View Options

python_modules/dagster-graphql/dagster_graphql/schema/sensors.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_execute_pipeline.py

View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_permissions.py

ReadOnlyError => UnauthorizedErrorClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 41375

js_modules/dagit/packages/core/src/app/PythonErrorInfo.tsx

js_modules/dagit/packages/core/src/app/types/ReadOnlyErrorFragment.ts

js_modules/dagit/packages/core/src/app/types/UnauthorizedErrorFragment.ts

js_modules/dagit/packages/core/src/assets/types/AssetWipeMutation.ts

js_modules/dagit/packages/core/src/graphql/possibleTypes.generated.json

js_modules/dagit/packages/core/src/graphql/schema.graphql

js_modules/dagit/packages/core/src/instance/InstanceBackfills.tsx

js_modules/dagit/packages/core/src/instance/types/CancelBackfill.ts

js_modules/dagit/packages/core/src/instance/types/resumeBackfill.ts

js_modules/dagit/packages/core/src/nav/ReloadRepositoryLocationButton.tsx

js_modules/dagit/packages/core/src/nav/types/ReloadRepositoryLocationMutation.ts

js_modules/dagit/packages/core/src/partitions/PartitionsBackfill.tsx

js_modules/dagit/packages/core/src/partitions/types/LaunchPartitionBackfill.ts

js_modules/dagit/packages/core/src/runs/DeletionDialog.tsx

js_modules/dagit/packages/core/src/runs/RunUtils.tsx

js_modules/dagit/packages/core/src/runs/TerminationDialog.tsx

js_modules/dagit/packages/core/src/runs/types/Delete.ts

js_modules/dagit/packages/core/src/runs/types/LaunchPipelineExecution.ts

js_modules/dagit/packages/core/src/runs/types/LaunchPipelineReexecution.ts

js_modules/dagit/packages/core/src/runs/types/Terminate.ts

js_modules/dagit/packages/core/src/schedules/types/ReconcileSchedulerState.ts

js_modules/dagit/packages/core/src/sensors/types/SensorRootQuery.ts

js_modules/dagit/packages/core/src/sensors/types/StartSensor.ts

js_modules/dagit/packages/core/src/sensors/types/StopSensor.ts

js_modules/dagit/packages/core/src/workspace/types/ReloadWorkspaceMutation.ts

js_modules/dagit/packages/core/src/workspace/useReloadWorkspace.tsx

python_modules/dagster-graphql/dagster_graphql/implementation/utils.py

python_modules/dagster-graphql/dagster_graphql/schema/backfill.py

python_modules/dagster-graphql/dagster_graphql/schema/errors.py

python_modules/dagster-graphql/dagster_graphql/schema/roots/mutation.py

python_modules/dagster-graphql/dagster_graphql/schema/schedules/__init__.py

python_modules/dagster-graphql/dagster_graphql/schema/sensors.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_execute_pipeline.py

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_permissions.py

ReadOnlyError => UnauthorizedError
ClosedPublic
Actions

Revision Contents
Changeset List

python_modules/dagster-graphql/dagster_graphql/schema/schedules/init.py