Page MenuHomeElementl
Differential D8752

Clean up marshalling of multiple inputs
ClosedPublic
Actions

Authored by • max on Jul 7 2021, 10:46 PM.
Tags
None
Referenced Files
F2894008: D8752.diff
Sun, Mar 26, 10:11 AM
Unknown Object (File)
Fri, Mar 10, 9:01 PM
Unknown Object (File)
Mon, Mar 6, 5:12 PM
Unknown Object (File)
Feb 22 2023, 4:05 PM
Unknown Object (File)
Feb 11 2023, 10:34 PM
Unknown Object (File)
Feb 11 2023, 7:04 PM
Unknown Object (File)
Feb 10 2023, 9:46 AM
Unknown Object (File)
Feb 9 2023, 6:59 PM
View All 52 Files
Subscribers
None

Details

Reviewers
alangenfeld
Commits
R1:07510f68022e: Clean up marshalling of multiple inputs
Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
dagstermill-fixes
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• max created this revision.Jul 7 2021, 10:46 PM
• max updated this revision to Diff 41174.Jul 7 2021, 10:53 PM

blk

• max updated this revision to Diff 41175.Jul 7 2021, 10:54 PM

fix test

Harbormaster failed remote builds in B33381: Diff 41172!Jul 7 2021, 11:08 PM
Harbormaster failed remote builds in B33383: Diff 41174!Jul 7 2021, 11:14 PM
Harbormaster completed remote builds in B33384: Diff 41175.Jul 7 2021, 11:18 PM
• max requested review of this revision.Jul 7 2021, 11:18 PM
• max added a reviewer: alangenfeld.Jul 8 2021, 4:46 PM
alangenfeld accepted this revision.Jul 8 2021, 4:49 PM

assuming the test failed before and works now, im good with this

python_modules/libraries/dagstermill/dagstermill/solids.py
143

this same path is used for read and write? surprised its not in two callsites

This revision is now accepted and ready to land.Jul 8 2021, 4:49 PM
• max added inline comments.Jul 8 2021, 5:53 PM
python_modules/libraries/dagstermill/dagstermill/solids.py
143

read:

for (output_name, output_def) in step_execution_context.solid_def.output_dict.items():
       data_dict = output_nb.scraps.data_dict
       if output_name in data_dict:
           value = read_value(output_def.dagster_type, data_dict[output_name])

           yield Output(value, output_name)
Closed by commit R1:07510f68022e: Clean up marshalling of multiple inputs (authored by • max). · Explain WhyJul 8 2021, 7:08 PM
This revision was automatically updated to reflect the committed changes.
• max added a commit: R1:07510f68022e: Clean up marshalling of multiple inputs.

Revision Contents
Changeset List

PathSize
python_modules/
libraries/
dagstermill/
dagstermill/
examples/
16 lines
11 lines
dagstermill_tests/
10 lines

Diff 41175

View Options

python_modules/libraries/dagstermill/dagstermill/examples/repository.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill/solids.py

Loading...
View Options

python_modules/libraries/dagstermill/dagstermill_tests/test_solids.py

Loading...