Page MenuHomeElementl

Clean up marshalling of multiple inputs
ClosedPublic

Authored by max on Jul 7 2021, 10:46 PM.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

max requested review of this revision.Jul 7 2021, 11:18 PM

assuming the test failed before and works now, im good with this

python_modules/libraries/dagstermill/dagstermill/solids.py
143

this same path is used for read and write? surprised its not in two callsites

This revision is now accepted and ready to land.Jul 8 2021, 4:49 PM
python_modules/libraries/dagstermill/dagstermill/solids.py
143

read:

for (output_name, output_def) in step_execution_context.solid_def.output_dict.items():
       data_dict = output_nb.scraps.data_dict
       if output_name in data_dict:
           value = read_value(output_def.dagster_type, data_dict[output_name])

           yield Output(value, output_name)
This revision was automatically updated to reflect the committed changes.