Add 'check_heartbeats' flag to DagsterDaemonController.check_daemon_loop
ClosedPublic
Actions

Authored by • dgibson on Jul 7 2021, 7:53 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Mar 22, 12:14 AM

	Unknown Object (File)
	Mon, Mar 20, 11:15 PM

	Unknown Object (File)
	Mon, Mar 20, 10:15 PM

	Unknown Object (File)
	Mon, Mar 20, 9:26 PM

	Unknown Object (File)
	Tue, Mar 14, 3:09 AM

	Unknown Object (File)
	Fri, Mar 10, 10:52 PM

	Unknown Object (File)
	Feb 11 2023, 3:40 PM

	Unknown Object (File)
	Feb 11 2023, 12:12 PM

View All 38 Files

Subscribers

None

Details

Reviewers

• johann
• jordansanders
• rexledesma

Commits

R1:5266c4d798e0: Add 'check_heartbeats' flag to DagsterDaemonController.check_daemon_loop

Summary

This allows some daemon controlelrs to still check that threads are alive, but not check heartbeats.

Test Plan

Diff Detail

Repository

R1 dagster

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• dgibson created this revision.Jul 7 2021, 7:53 PM

Harbormaster completed remote builds in B33347: Diff 41126.Jul 7 2021, 8:18 PM

• dgibson requested review of this revision.Jul 7 2021, 8:18 PM

• jordansanders accepted this revision.Jul 7 2021, 8:49 PM

This revision is now accepted and ready to land.Jul 7 2021, 8:49 PM

Closed by commit R1:5266c4d798e0: Add 'check_heartbeats' flag to DagsterDaemonController.check_daemon_loop (authored by • dgibson). · Explain WhyJul 7 2021, 9:41 PM

This revision was automatically updated to reflect the committed changes.

• dgibson added a commit: R1:5266c4d798e0: Add 'check_heartbeats' flag to DagsterDaemonController.check_daemon_loop.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

daemon/

controller.py

7 lines

Diff 41126

View Options

python_modules/dagster/dagster/daemon/controller.py

Add 'check_heartbeats' flag to DagsterDaemonController.check_daemon_loopClosedPublicActions