Page MenuHomePhabricator

Remove lambda_solid from tutorial and examples
ClosedPublic

Authored by schrockn on Thu, Aug 22, 6:53 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:bb85c68508b4: Remove lambda_solid from tutorial and examples
Summary

This has always been a bit problematic and now we have evidence that it
is actively causing confusion for folks getting up to speed. Post py3 type
annotations this is actually more reasonable to deal with, and it only
requires having a placeholder variable for the context variable.

Test Plan

Look at docs

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

schrockn created this revision.Thu, Aug 22, 6:53 PM

Yeah agree that it's not a slam dunk

I'm leaning yes. One anecdote is from a recent call watching some one want to log something and having to import a new thing, change the call sig, then add the context.log to do it.

Pros:

  • less concepts to learn

Cons:

  • unused context arg

Curious to hear opinions from others.

prha added a subscriber: prha.Mon, Aug 26, 10:47 PM

I prefer removing lambda_solid... I don't think the extra parameter is that crazy / unusual.

schrockn updated this revision to Diff 4043.Tue, Aug 27, 9:39 PM
schrockn retitled this revision from RFC: Remove lambda_solid from tutorial to Remove lambda_solid from tutorial and examples.

up

alangenfeld accepted this revision.Wed, Aug 28, 8:28 PM

fire at will

This revision is now accepted and ready to land.Wed, Aug 28, 8:28 PM
This revision was automatically updated to reflect the committed changes.