Page MenuHomeElementl

Create migration to extract asset_keys columns for asset catalog perf
ClosedPublic

Authored by prha on Wed, Jul 7, 6:42 AM.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

prha requested review of this revision.Wed, Jul 7, 7:27 AM

should this and D8629 be merged? that way its a single migration instead of 2 ?

python_modules/dagster/dagster/core/storage/event_log/schema.py
37–40

divergent types?

python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py
427–432

dupe comments

  • make instance migration optional

@cdecarolis - I was chatting w/ Sandy, and landed on this approach, which doesn't force the instance migration (e.g. doesn't throw a DBException). We can support this at the expense of the code complexity of the two code paths, checking to see if the migration has been run.

We may want to consider the same approach for D8629.

We may want to consider the same approach for D8629.

theoretically - the DB error should only happen when someone tries to use the mode filter - so might already be close to what we hope. Will need to explicitly add that to test plan tho

push_n_pray

python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py
157–160

nit: wicked nesting - refactor welcome

This revision is now accepted and ready to land.Wed, Jul 7, 9:15 PM

rebase, change the down_revision for postgres/mysql migration scripts to avoid drift

update back compat snapshot, rebase docs snapshot

This revision was landed with ongoing or failed builds.Thu, Jul 8, 6:12 PM
This revision was automatically updated to reflect the committed changes.