Page MenuHomeElementl

Solid -> Node
ClosedPublic

Authored by alangenfeld on Jul 6 2021, 7:53 PM.

Details

Summary

Another in the rename stream, just changes the type name. Variables etc to be updated in future.

I think it'll be useful to have something like Node[Solid] & Node[Graph] or SolidNode and SolidGraph to distinguish, but for now just reflect the existing code operating in terms of a single type with getters to distinguish.

depends on D8714

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 6 2021, 8:59 PM
Harbormaster failed remote builds in B33267: Diff 41013!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 14 2021, 4:29 PM
Harbormaster failed remote builds in B33693: Diff 41605!

Nice -- one step closer to banishing solids from this world

This revision is now accepted and ready to land.Jul 14 2021, 5:49 PM
This revision was automatically updated to reflect the committed changes.