Page MenuHomeElementl

SolidHandle -> NodeHandle
ClosedPublic

Authored by alangenfeld on Jul 6 2021, 7:07 PM.

Details

Summary

One of many renames to make things coherent with the CompositeSolid -> Graph change

This object isn't top-level exposed so should be safe to change.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 6 2021, 7:31 PM
Harbormaster failed remote builds in B33258: Diff 40999!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 6 2021, 8:00 PM
Harbormaster failed remote builds in B33263: Diff 41007!
prha added inline comments.
python_modules/dagster/dagster/core/definitions/dependency.py
370

do we need to start keeping backcompat tests for these fallbacks?

This revision is now accepted and ready to land.Jul 15 2021, 3:29 PM
python_modules/dagster/dagster/core/definitions/dependency.py
370

existing back compat tests catch this - I can double check again to be sure

This revision was landed with ongoing or failed builds.Jul 16 2021, 4:53 PM
This revision was automatically updated to reflect the committed changes.