Page MenuHomeElementl
Differential D8706

de-experimental dynamic mapping & collect
ClosedPublic
Actions

Authored by alangenfeld on Tue, Jul 6, 3:50 PM.

Details

Reviewers
owen
sandyryza
yuhan
Commits
R1:0c0525612508: de-experimental dynamic mapping & collect
Summary

resolve https://github.com/dagster-io/dagster/issues/4189

Test Plan

look for experimental wording and warnings on dynamic output code & docs, remove all

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

alangenfeld created this revision.Tue, Jul 6, 3:50 PM
alangenfeld updated this revision to Diff 40969.Tue, Jul 6, 4:06 PM

rebase

Harbormaster failed remote builds in B33229: Diff 40964!Tue, Jul 6, 4:14 PM
Harbormaster completed remote builds in B33233: Diff 40969.Tue, Jul 6, 4:31 PM
alangenfeld requested review of this revision.Tue, Jul 6, 4:31 PM
rexledesma added a subscriber: rexledesma.Tue, Jul 6, 4:33 PM

Should we also remove references out of the dagster.experimental.__init__.py ?

alangenfeld added a comment.Tue, Jul 6, 5:57 PM

Should we also remove references out of the dagster.experimental.__init__.py ?

I did not do that to avoid breaking people, since its so low cost to keep it around. I can add a comment in the file

alangenfeld updated this revision to Diff 40984.Tue, Jul 6, 6:03 PM

address imports

Harbormaster failed remote builds in B33247: Diff 40984!Tue, Jul 6, 6:26 PM
alangenfeld updated this revision to Diff 40991.Tue, Jul 6, 6:34 PM

snapshot

Harbormaster failed remote builds in B33253: Diff 40991!Tue, Jul 6, 6:57 PM
sandyryza accepted this revision.Tue, Jul 6, 8:25 PM

Yeehaw!

This revision is now accepted and ready to land.Tue, Jul 6, 8:25 PM
This revision was landed with ongoing or failed builds.Tue, Jul 6, 8:33 PM
Closed by commit R1:0c0525612508: de-experimental dynamic mapping & collect (authored by alangenfeld). · Explain Why
This revision was automatically updated to reflect the committed changes.
alangenfeld added a commit: R1:0c0525612508: de-experimental dynamic mapping & collect.

Revision Contents
Changeset List

PathSize
docs/
content/
2 lines
concepts/
solids-pipelines/
7 lines
sphinx/
sections/
api/
apidocs/
6 lines
examples/
docs_snippets/
docs_snippets/
concepts/
solids_pipelines/
dynamic_pipeline/
3 lines
python_modules/
dagster-graphql/
dagster_graphql_tests/
graphql/
3 lines
dagster/
dagster/
4 lines
core/
definitions/
2 lines
experimental/
2 lines
dagster_tests/
core_tests/
definitions_tests/
11 lines
dynamic_tests/
3 lines
3 lines
10 lines
3 lines
10 lines
execution_tests/
3 lines
hook_tests/
3 lines
storage_tests/
3 lines
general_tests/
compat_tests/
3 lines
libraries/
dagster-gcp/
dagster_gcp_tests/
gcs_tests/
3 lines
dagster-k8s/
dagster_k8s_tests/
unit_tests/
3 lines

Diff 41020

View Options

docs/content/_apidocs.mdx

Loading...
View Options

docs/content/concepts/solids-pipelines/pipelines.mdx

Loading...
View Options

docs/sphinx/sections/api/apidocs/dynamic.rst

Loading...
View Options

examples/docs_snippets/docs_snippets/concepts/solids_pipelines/dynamic_pipeline/dynamic_pipeline.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py

Loading...
View Options

python_modules/dagster/dagster/__init__.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/__init__.py

Loading...
View Options

python_modules/dagster/dagster/experimental/__init__.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_solid_io.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/dynamic_tests/test_dsl.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/dynamic_tests/test_dynamic_execution.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/dynamic_tests/test_dynamic_output.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/dynamic_tests/test_not_allowed.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/dynamic_tests/test_reexecute.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/execution_tests/test_execute_in_process.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/hook_tests/test_hook_run.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/storage_tests/test_asset_lineage.py

Loading...
View Options

python_modules/dagster/dagster_tests/general_tests/compat_tests/test_execution_plan_snapshot.py

Loading...
View Options

python_modules/libraries/dagster-gcp/dagster_gcp_tests/gcs_tests/test_io_manager.py

Loading...
View Options

python_modules/libraries/dagster-k8s/dagster_k8s_tests/unit_tests/test_resource_tags.py

Loading...