Differential D8702

mypy fixes to make master green
ClosedPublic
Actions

Authored by dgibson on Jul 3 2021, 4:21 AM.

Details

Reviewers

max

Commits

R1:1b3437846655: mypy fixes to make master green

Summary

A few mypy issues snuck in at the last minute on Friday

Test Plan

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dgibson created this revision.Jul 3 2021, 4:21 AM

dgibson mentioned this in D8696: Typehints for MayHaveInstanceWeakref.Jul 3 2021, 4:22 AM

Harbormaster completed remote builds in B33199: Diff 40923.Jul 3 2021, 4:47 AM

dgibson requested review of this revision.Jul 3 2021, 4:47 AM

max accepted this revision.Jul 4 2021, 8:00 PM

This revision is now accepted and ready to land.Jul 4 2021, 8:00 PM

Closed by commit R1:1b3437846655: mypy fixes to make master green (authored by dgibson). · Explain WhyJul 4 2021, 8:04 PM

This revision was automatically updated to reflect the committed changes.

dgibson added a commit: R1:1b3437846655: mypy fixes to make master green.

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

core/

instance/

__init__.py

9 lines

storage/

event_log/

base.py

2 lines

in_memory.py

2 lines

sql_event_log.py

2 lines

sqlite/

sqlite_event_log.py

2 lines

Diff 40931

View Options

python_modules/dagster/dagster/core/instance/init.py

View Options

python_modules/dagster/dagster/core/storage/event_log/base.py

View Options

python_modules/dagster/dagster/core/storage/event_log/in_memory.py

View Options

python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py

View Options

python_modules/dagster/dagster/core/storage/event_log/sqlite/sqlite_event_log.py

mypy fixes to make master greenClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40931

python_modules/dagster/dagster/core/instance/__init__.py

python_modules/dagster/dagster/core/storage/event_log/base.py

python_modules/dagster/dagster/core/storage/event_log/in_memory.py

python_modules/dagster/dagster/core/storage/event_log/sql_event_log.py

python_modules/dagster/dagster/core/storage/event_log/sqlite/sqlite_event_log.py

mypy fixes to make master green
ClosedPublic
Actions

Revision Contents
Changeset List

python_modules/dagster/dagster/core/instance/init.py