Page MenuHomeElementl
Differential D8696

Typehints for MayHaveInstanceWeakref
ClosedPublic
Actions

Authored by • max on Jul 2 2021, 9:37 PM.
Tags
None
Referenced Files
F2988818: D8696.id.diff
Mon, Jun 5, 4:06 AM
F2988804: D8696.id40873.diff
Mon, Jun 5, 2:51 AM
Unknown Object (File)
Sun, May 14, 1:26 PM
Unknown Object (File)
Sun, May 14, 1:26 PM
Unknown Object (File)
Fri, May 12, 7:34 PM
Unknown Object (File)
Thu, May 11, 12:15 PM
Unknown Object (File)
Wed, May 10, 2:25 AM
Unknown Object (File)
Wed, May 10, 1:23 AM
View All 80 Files
Subscribers
None

Details

Reviewers
• dgibson
alangenfeld
• prha
• sashank
Commits
R1:a566b62cf58a: Typehints for MayHaveInstanceWeakref
Test Plan

Unit

Diff Detail

Repository
R1 dagster
Branch
weakref-typehints
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• max created this revision.Jul 2 2021, 9:37 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2021, 10:02 PM
Harbormaster failed remote builds in B33158: Diff 40873!
• max updated this revision to Diff 40887.Jul 2 2021, 10:08 PM

up

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2021, 10:52 PM
Harbormaster failed remote builds in B33170: Diff 40887!
• max requested review of this revision.Jul 3 2021, 12:06 AM

irrelevant stochastic test failure in dagster pandas

• dgibson accepted this revision.Jul 3 2021, 12:06 AM

pandas should be behaving better if you rebase

This revision is now accepted and ready to land.Jul 3 2021, 12:06 AM
• max updated this revision to Diff 40912.Jul 3 2021, 12:28 AM

up

This revision was landed with ongoing or failed builds.Jul 3 2021, 12:35 AM
Closed by commit R1:a566b62cf58a: Typehints for MayHaveInstanceWeakref (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: R1:a566b62cf58a: Typehints for MayHaveInstanceWeakref.
Harbormaster failed remote builds in B33192: Diff 40912!Jul 3 2021, 1:11 AM
• dgibson added a comment.Jul 3 2021, 4:03 AM

on a diff that adds typehints its probably a good idea to wait for the mypy test suite to pass before landing

• dgibson added a comment.Jul 3 2021, 4:22 AM

https://dagster.phacility.com/D8702 fixes that and one other mypy issue that snuck in elsewhere

Revision Contents
Changeset List

PathSize
python_modules/
dagster/
dagster/
core/
instance/
6 lines

Diff 40912

View Options

python_modules/dagster/dagster/core/instance/__init__.py

Loading...