Typehints for MayHaveInstanceWeakref
ClosedPublic
Actions

Authored by • max on Jul 2 2021, 9:37 PM.

Details

Reviewers

• dgibson
alangenfeld
• prha
• sashank

Commits

R1:a566b62cf58a: Typehints for MayHaveInstanceWeakref

Test Plan

Unit

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• max created this revision.Jul 2 2021, 9:37 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2021, 10:02 PM

Harbormaster failed remote builds in B33158: Diff 40873!

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2021, 10:52 PM

Harbormaster failed remote builds in B33170: Diff 40887!

irrelevant stochastic test failure in dagster pandas

pandas should be behaving better if you rebase

This revision is now accepted and ready to land.Jul 3 2021, 12:06 AM

This revision was landed with ongoing or failed builds.Jul 3 2021, 12:35 AM

Closed by commit R1:a566b62cf58a: Typehints for MayHaveInstanceWeakref (authored by • max). · Explain Why

This revision was automatically updated to reflect the committed changes.

• max added a commit: R1:a566b62cf58a: Typehints for MayHaveInstanceWeakref.

Harbormaster failed remote builds in B33192: Diff 40912!Jul 3 2021, 1:11 AM

on a diff that adds typehints its probably a good idea to wait for the mypy test suite to pass before landing

https://dagster.phacility.com/D8702 fixes that and one other mypy issue that snuck in elsewhere

Revision Contents
Changeset List

Path

Size

python_modules/

dagster/

core/

instance/

__init__.py

6 lines

Diff 40913

View Options

python_modules/dagster/dagster/core/instance/init.py

Typehints for MayHaveInstanceWeakrefClosedPublicActions