Page MenuHomeElementl

Typehints for MayHaveInstanceWeakref
ClosedPublic

Authored by max on Jul 2 2021, 9:37 PM.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2021, 10:02 PM
Harbormaster failed remote builds in B33158: Diff 40873!
Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2021, 10:52 PM
Harbormaster failed remote builds in B33170: Diff 40887!
max requested review of this revision.Jul 3 2021, 12:06 AM

irrelevant stochastic test failure in dagster pandas

pandas should be behaving better if you rebase

This revision is now accepted and ready to land.Jul 3 2021, 12:06 AM
This revision was landed with ongoing or failed builds.Jul 3 2021, 12:35 AM
This revision was automatically updated to reflect the committed changes.

on a diff that adds typehints its probably a good idea to wait for the mypy test suite to pass before landing

https://dagster.phacility.com/D8702 fixes that and one other mypy issue that snuck in elsewhere