Page MenuHomeElementl
Differential D8687

[crag] Pipeline.graph_name
ClosedPublic
Actions

Authored by alangenfeld on Jul 2 2021, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 31, 12:24 PM
Unknown Object (File)
Apr 30 2023, 10:24 PM
Unknown Object (File)
Apr 28 2023, 10:17 PM
Unknown Object (File)
Apr 28 2023, 7:43 PM
Unknown Object (File)
Apr 28 2023, 7:02 PM
Unknown Object (File)
Apr 27 2023, 4:28 PM
Unknown Object (File)
Mar 31 2023, 3:14 PM
Unknown Object (File)
Mar 23 2023, 5:26 AM
View All 59 Files
Subscribers
None

Details

Reviewers
• sandyryza
• bengotow
• prha
Commits
R1:d1f66a9d87b5: [crag] Pipeline.graph_name
Summary

the shortest path to getting graph name de-dupe ability, derived from exploration for more extensive changes in D8675

Test Plan

added tests

Diff Detail

Repository
R1 dagster
Branch
shortcut
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

alangenfeld created this revision.Jul 2 2021, 7:59 PM
alangenfeld updated this revision to Diff 40819.Jul 2 2021, 8:01 PM

working ver

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2021, 8:22 PM
Harbormaster failed remote builds in B33118: Diff 40819!
Harbormaster failed remote builds in B33116: Diff 40817!Jul 2 2021, 8:43 PM
alangenfeld updated this revision to Diff 40872.Jul 2 2021, 9:35 PM

fix tests

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2021, 10:00 PM
Harbormaster failed remote builds in B33157: Diff 40872!
alangenfeld updated this revision to Diff 40945.Jul 6 2021, 2:10 PM

snapshot

Harbormaster completed remote builds in B33217: Diff 40945.Jul 6 2021, 2:34 PM
alangenfeld requested review of this revision.Jul 6 2021, 2:34 PM
• sandyryza accepted this revision.Jul 7 2021, 5:16 AM

I might not be the best person to review this, but looks reasonable to me.

This revision is now accepted and ready to land.Jul 7 2021, 5:16 AM
• prha accepted this revision.Jul 7 2021, 6:39 AM
Closed by commit R1:d1f66a9d87b5: [crag] Pipeline.graph_name (authored by alangenfeld). · Explain WhyJul 7 2021, 2:34 PM
This revision was automatically updated to reflect the committed changes.
alangenfeld added a commit: R1:d1f66a9d87b5: [crag] Pipeline.graph_name.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
src/
graphql/
2 lines
instigation/
types/
python_modules/
dagster-graphql/
dagster_graphql/
schema/
pipelines/
4 lines
dagster_graphql_tests/
graphql/
8 lines
snapshots/
65 lines
dagster/
dagster/
core/
definitions/
14 lines
host_representation/
5 lines
snap/
58 lines
dagster_tests/
core_tests/
definitions_tests/
51 lines
snap_tests/
snapshots/

Diff 40872

View Options

js_modules/dagit/packages/core/src/graphql/schema.graphql

Loading...
View Options

js_modules/dagit/packages/core/src/instigation/types/LaunchedRunListQuery.ts

Loading...
View Options

js_modules/dagit/packages/core/src/instigation/types/TickHistoryQuery.ts

Loading...
View Options

js_modules/dagit/packages/core/src/instigation/types/TickTagFragment.ts

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql/schema/pipelines/pipeline.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/setup.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/snapshots/snap_test_pipeline_snapshot.py

Loading...
View Options

python_modules/dagster-graphql/dagster_graphql_tests/graphql/test_graph.py

Loading...
View Options

python_modules/dagster/dagster/core/definitions/repository.py

Loading...
View Options

python_modules/dagster/dagster/core/host_representation/represented.py

Loading...
View Options

python_modules/dagster/dagster/core/snap/pipeline_snapshot.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/definitions_tests/test_repository_definition.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_active_data.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_execution_plan.py

Loading...
View Options

python_modules/dagster/dagster_tests/core_tests/snap_tests/snapshots/snap_test_pipeline_snap.py

Loading...