Page MenuHomeElementl

Make context argument optional on resource definition
ClosedPublic

Authored by cdecarolis on Jul 2 2021, 7:48 PM.

Details

Summary

title. Still need to add more tests.

Test Plan

unit tests migration

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Jul 2 2021, 8:15 PM
Harbormaster failed remote builds in B33113: Diff 40814!

Fix mypy issue and kwargs (?) issue

python_modules/dagster/dagster/core/definitions/resource.py
263

For solids, we no longer require a context arg if there are required resource keys. If we do want to have this requirement, should this be or instead of and?

This revision now requires changes to proceed.Wed, Jul 7, 5:37 AM
python_modules/dagster/dagster/core/definitions/resource.py
263

I'm fine with getting rid of this requirement tbh.

Remove required_resource_keys context requirement

This revision was not accepted when it landed; it landed in state Needs Review.Thu, Jul 8, 4:59 PM
This revision was automatically updated to reflect the committed changes.