I don't personally love git-hooks and find them to often be more of a hinderance than a help: https://www.thoughtworks.com/en-us/insights/blog/pre-commit-don-t-git-hooked

But if we do want to go in this direction, I think we should continue to make our use of black explicit in our setup.py (or at least in our make dev_install) so that developers can continue to run it ad hoc or automatically in their editors.

Take it with a grain of salt, but it looks like we backed away from pre-commit hooks once before as well:

https://dagster.phacility.com/D21

And later removed them entirely:

https://dagster.phacility.com/D558

Although I suspect the issue that caused us to remove them is no longer a problem.

I faintly remember some weird shit around statefulness of how pre-commit worked when we had it set up but im struggling to remember the details

make black has reference in contributing.mdx that'll need update

Overall, pretty nice experience. pip install pre-commit and you're off to the races.

you need to run pre-commit install too to get the hooks in to git installed

Should maybe post in #core-team or something to solicit feedback from others who may care or have past experience with pre-commit

I don't personally love pre-commit hooks but if we do this we should think about also adding mypy, isort