Page MenuHomeElementl
Differential D8681

Fix circular import
ClosedPublic
Actions

Authored by • max on Jul 2 2021, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 21, 3:23 PM
Unknown Object (File)
Fri, Mar 10, 9:01 PM
Unknown Object (File)
Thu, Mar 9, 12:32 AM
Unknown Object (File)
Sat, Mar 4, 11:11 PM
Unknown Object (File)
Wed, Mar 1, 12:16 AM
Unknown Object (File)
Feb 23 2023, 5:11 AM
Unknown Object (File)
Feb 14 2023, 2:53 AM
Unknown Object (File)
Feb 10 2023, 6:30 PM
View All 63 Files
Subscribers
None

Details

Reviewers
• dgibson
alangenfeld
• prha
Commits
R1:6c351f358831: Fix circular import
Test Plan

Manually import: from dagster_graphql.implementation.utils import capture_error

Diff Detail

Repository
R1 dagster
Branch
circular-import
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

• max created this revision.Jul 2 2021, 6:06 PM
• dgibson published this revision for review.Jul 2 2021, 6:12 PM
• dgibson added inline comments.
python_modules/dagster-graphql/dagster_graphql/implementation/utils.py
11

I thought you preferred relative imports - not when they're inline?

• dgibson accepted this revision.Jul 2 2021, 6:12 PM
This revision is now accepted and ready to land.Jul 2 2021, 6:12 PM
Harbormaster failed remote builds in B33096: Diff 40795!Jul 2 2021, 6:29 PM
• max added a comment.Jul 2 2021, 6:56 PM

i think this is marginal -- it is really expected to be imported after the package so there's a case for making it absolute. i am just following the existing pattern later in this file though

This revision was landed with ongoing or failed builds.Jul 2 2021, 7:33 PM
Closed by commit R1:6c351f358831: Fix circular import (authored by • max). · Explain Why
This revision was automatically updated to reflect the committed changes.
• max added a commit: R1:6c351f358831: Fix circular import.

Revision Contents
Changeset List

PathSize
python_modules/
dagster-graphql/
dagster_graphql/
implementation/
3 lines

Diff 40795

View Options

python_modules/dagster-graphql/dagster_graphql/implementation/utils.py

Loading...