Page MenuHomeElementl

Fix circular import
ClosedPublic

Authored by max on Jul 2 2021, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Aug 9, 8:40 PM
Unknown Object (File)
Tue, Aug 2, 1:26 PM
Unknown Object (File)
Fri, Jul 15, 3:00 AM
Unknown Object (File)
Fri, Jul 15, 3:00 AM
Unknown Object (File)
Fri, Jul 15, 3:00 AM
Unknown Object (File)
Jul 10 2022, 6:42 PM
Unknown Object (File)
Jul 4 2022, 11:54 AM
Unknown Object (File)
Jun 23 2022, 5:11 PM
Subscribers
None

Details

Test Plan

Manually import: from dagster_graphql.implementation.utils import capture_error

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dgibson added inline comments.
python_modules/dagster-graphql/dagster_graphql/implementation/utils.py
11

I thought you preferred relative imports - not when they're inline?

This revision is now accepted and ready to land.Jul 2 2021, 6:12 PM

i think this is marginal -- it is really expected to be imported after the package so there's a case for making it absolute. i am just following the existing pattern later in this file though

This revision was landed with ongoing or failed builds.Jul 2 2021, 7:33 PM
Closed by commit R1:6c351f358831: Fix circular import (authored by max). · Explain Why
This revision was automatically updated to reflect the committed changes.