Page MenuHomeElementl

Fix circular import
ClosedPublic

Authored by max on Jul 2 2021, 6:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jan 22, 7:09 PM
Unknown Object (File)
Wed, Jan 11, 6:35 PM
Unknown Object (File)
Jan 4 2023, 11:06 PM
Unknown Object (File)
Dec 26 2022, 3:13 AM
Unknown Object (File)
Dec 19 2022, 11:52 PM
Unknown Object (File)
Dec 19 2022, 7:18 AM
Unknown Object (File)
Dec 6 2022, 6:18 AM
Unknown Object (File)
Nov 24 2022, 3:39 PM
Subscribers
None

Details

Test Plan

Manually import: from dagster_graphql.implementation.utils import capture_error

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dgibson added inline comments.
python_modules/dagster-graphql/dagster_graphql/implementation/utils.py
11

I thought you preferred relative imports - not when they're inline?

This revision is now accepted and ready to land.Jul 2 2021, 6:12 PM

i think this is marginal -- it is really expected to be imported after the package so there's a case for making it absolute. i am just following the existing pattern later in this file though

This revision was landed with ongoing or failed builds.Jul 2 2021, 7:33 PM
Closed by commit R1:6c351f358831: Fix circular import (authored by max). · Explain Why
This revision was automatically updated to reflect the committed changes.