Page MenuHomeElementl

[dagit] Add "Download debug file" to Run page
ClosedPublic

Authored by dish on Jul 1 2021, 3:53 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 7, 11:37 AM
Unknown Object (File)
Mon, Jan 23, 8:08 PM
Unknown Object (File)
Thu, Jan 19, 12:43 PM
Unknown Object (File)
Sun, Jan 15, 6:06 PM
Unknown Object (File)
Thu, Jan 12, 3:53 PM
Unknown Object (File)
Jan 4 2023, 4:15 AM
Unknown Object (File)
Jan 1 2023, 3:30 PM
Unknown Object (File)
Dec 29 2022, 9:57 PM
Subscribers
None

Details

Summary

Modify the upper right of the Run page to make the button a menu with two items:

  • View tags and configuration (opens a dialog, just as before)
  • Download debug file (same as on the Runs list view)
Test Plan

View a Run, verify that the menu behaves correctly for both items.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

my reaction seeing this is I think it has low discoverability, expect i will have to tell users click "view run metadata" then "download debug file" to find it. That is still better than the status quo of having to go to the runs page, so I would be fine with this.

Any other ui treatments you think would work well here that would lend to discoverability?

Code lgtm, but I agree we could play with the UI treatment a bit. Is the debug download feature just for folks to send to us, or can they inspect it themselves? If it's something we want people to find easily, we could potentially put two small icon buttons side by side in the top right area with the "tags" icon and the "download" icon and show the labels on hover? I think the tags icon is good enough people will guess what it does and we might end up with a whole toolbar of actions up there eventually...

This revision is now accepted and ready to land.Jul 6 2021, 12:37 PM

I don't really like showing an affordance for "Download debug file" alongside "View tags and config" given that it's a) fairly prominent screen space and b) an action that will be taken on a tiny fraction of views of the Run page.

we might end up with a whole toolbar of actions up there eventually...

Yeah, that could be...

Screen Shot 2021-07-06 at 9.45.51 AM.png (274×2 px, 84 KB)

I'll go with this for now, we can revisit.

This revision was landed with ongoing or failed builds.Jul 6 2021, 6:43 PM
This revision was automatically updated to reflect the committed changes.