Split launcher tests into a module per function
ClosedPublic
Actions

Authored by • jordansanders on Jun 30 2021, 8:46 PM.

Details

Reviewers

• dgibson
alangenfeld
• johann

Commits

R1:08b6c70cd589: Split launcher tests into a module per function

Summary

Depends on D8639.

Test Plan

unit

Diff Detail

Repository

R1 dagster

Lint

Lint Passed

Unit

No Test Coverage

Event Timeline

• jordansanders created this revision.Jun 30 2021, 8:46 PM

• jordansanders added a child revision: D8641: Ignore dagster.ExperimentalWarning.

Harbormaster completed remote builds in B32939: Diff 40595.Jun 30 2021, 9:11 PM

• jordansanders requested review of this revision.Jun 30 2021, 9:11 PM

• dgibson accepted this revision.Jul 1 2021, 2:31 PM

This revision is now accepted and ready to land.Jul 1 2021, 2:31 PM

Rebase

Harbormaster completed remote builds in B33005: Diff 40681.Jul 1 2021, 6:54 PM

update

Harbormaster failed remote builds in B33129: Diff 40830!Jul 2 2021, 9:01 PM

This revision was landed with ongoing or failed builds.Jul 2 2021, 9:18 PM

Closed by commit R1:08b6c70cd589: Split launcher tests into a module per function (authored by • jordansanders). · Explain Why

This revision was automatically updated to reflect the committed changes.

• jordansanders added a commit: R1:08b6c70cd589: Split launcher tests into a module per function.

Revision Contents
Changeset List

Path

Size

python_modules/

libraries/

dagster-aws/

dagster_aws_tests/

ecs_tests/

launcher_tests/

__init__.py

test_launching.py

54 lines

test_termination.py

11 lines

	launcher_tests/

	conftest.py
	test_launcher.py

68 lines

repo.py

16 lines

repo.py

test_launcher.py

Diff 40830

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/init.py

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/conftest.py

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/repo.py

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/test_launching.py

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/test_termination.py

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/repo.py

View Options

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_launcher.py

Split launcher tests into a module per functionClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 40830

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/__init__.py

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/conftest.py

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/repo.py

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/test_launching.py

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/test_termination.py

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/repo.py

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/test_launcher.py

Split launcher tests into a module per function
ClosedPublic
Actions

Revision Contents
Changeset List

python_modules/libraries/dagster-aws/dagster_aws_tests/ecs_tests/launcher_tests/init.py