Page MenuHomeElementl

Stub AWS before instance construction

Authored by jordansanders on Jun 30 2021, 8:43 PM.
Referenced Files
Unknown Object (File)
Sun, May 14, 11:05 AM
Unknown Object (File)
Mon, May 8, 12:56 PM
Unknown Object (File)
Sun, May 7, 10:43 AM
Unknown Object (File)
Apr 20 2023, 1:39 AM
Unknown Object (File)
Apr 12 2023, 7:46 AM
Unknown Object (File)
Apr 1 2023, 2:38 PM
Unknown Object (File)
Mar 27 2023, 1:31 AM
Unknown Object (File)
Mar 27 2023, 1:15 AM



Previously, we were stubbing our AWS objects (the ECS resource and EC2
client) after an instance was constructed. This was simpler, but it
prevented us from using our stubbed objects in the launcher's
__init__ function.

Instead, we're now stubbing our AWS objects before the launcher has bee
initialized. Once the fixture is called, any call to boto3.client()
(with any arguments) will return our ecs fixture. Any call to
boto3.resource() (with any arguments) will return our ec2 fixture.
Should we ever make multiple calls to either boto3.client() or
boto3.resource(), we'll need to modify this fixture.

Now, we'll be able to use our stubbed objects inside the launcher's
__init__ - for example, if we wanted to do an invariant check to make
sure something like a cluster or task definition already exists.

Depends on D8638

Test Plan


Diff Detail

R1 dagster
Lint Not Applicable
Tests Not Applicable

Event Timeline

dgibson added inline comments.

as discussedin the other diff this pattern does not cleanup correctly, but we can sort that out on that diff

This revision is now accepted and ready to land.Jul 1 2021, 2:31 PM

Rearrange stack so this comes first