Refactor queries in PipelineExecutionRoot, which will make it simpler to implement a followup in which we prepopulate the config editor when there is a single preset.
Details
Details
- Reviewers
• bengotow • prha - Commits
- R1:d25b2b755498: [dagit] PipelineExecutionRoot refactor
View Playground for pipeline, verify proper rendering and behavior of the page.
Diff Detail
Diff Detail
- Repository
- R1 dagster
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| js_modules/dagit/packages/core/src/execute/PipelineExecutionRoot.tsx | ||
|---|---|---|
| 71–73 | This seems like it may no longer be relevant, as I can't find any way to switch pipelines while remaining in Playground view. | |
Comment Actions
This looks great! Amazing how much better useQuery is than the old stuff...
| js_modules/dagit/packages/core/src/execute/PipelineExecutionRoot.tsx | ||
|---|---|---|
| 71–73 | Yep I think this is reasonable. Technically if we held the page selection constant as you moved from pipeline to pipeline in the left nav I think this could still happen, but I think clicking pipelines always takes you to the overview page now. | |