Page MenuHomeElementl

[dagit] PipelineExecutionRoot refactor
ClosedPublic

Authored by dish on Jun 29 2021, 7:29 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 16 2022, 1:52 AM
Unknown Object (File)
Nov 18 2022, 12:20 AM
Unknown Object (File)
Nov 18 2022, 12:20 AM
Unknown Object (File)
Nov 18 2022, 12:20 AM
Unknown Object (File)
Nov 14 2022, 3:14 PM
Unknown Object (File)
Nov 12 2022, 1:14 PM
Unknown Object (File)
Nov 11 2022, 4:56 AM
Unknown Object (File)
Nov 8 2022, 9:14 AM
Subscribers
None

Details

Summary

Refactor queries in PipelineExecutionRoot, which will make it simpler to implement a followup in which we prepopulate the config editor when there is a single preset.

Test Plan

View Playground for pipeline, verify proper rendering and behavior of the page.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

js_modules/dagit/packages/core/src/execute/PipelineExecutionRoot.tsx
71–73

This seems like it may no longer be relevant, as I can't find any way to switch pipelines while remaining in Playground view.

This looks great! Amazing how much better useQuery is than the old stuff...

js_modules/dagit/packages/core/src/execute/PipelineExecutionRoot.tsx
71–73

Yep I think this is reasonable. Technically if we held the page selection constant as you moved from pipeline to pipeline in the left nav I think this could still happen, but I think clicking pipelines always takes you to the overview page now.

This revision is now accepted and ready to land.Jun 30 2021, 4:08 AM
This revision was automatically updated to reflect the committed changes.