Page MenuHomePhabricator

Break log storage out from run storage
ClosedPublic

Authored by max on Wed, Aug 21, 8:19 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:25e4bdf77590: Break log storage out from run storage
Summary

This will make log storage and run storage swappable, e.g. for hybrid SQLite/filesystem storage.

Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Wed, Aug 21, 8:19 PM
prha added a subscriber: prha.Wed, Aug 21, 8:24 PM
prha added inline comments.
python_modules/dagster/dagster/core/storage/runs.py
78

with the upcoming introduction of some sort of stderr/stdout log persistence, can we rename LogStorage to something more specific (e.g. EventLogStorage)

natekupp added inline comments.
python_modules/dagster/dagster/core/storage/runs.py
78

maybe even just EventStorage? :)

max added inline comments.Wed, Aug 21, 9:02 PM
python_modules/dagster/dagster/core/storage/runs.py
78

yep, very into it

max updated this revision to Diff 3907.Wed, Aug 21, 9:15 PM

EventLogStorage

max updated this revision to Diff 3910.Wed, Aug 21, 9:27 PM

Black

alangenfeld accepted this revision.Wed, Aug 21, 9:34 PM

move eventlog stuff to new file please

shipit

This revision is now accepted and ready to land.Wed, Aug 21, 9:34 PM
max updated this revision to Diff 3913.Wed, Aug 21, 9:56 PM

Reorganize

max updated this revision to Diff 3914.Wed, Aug 21, 9:59 PM

Black