Page MenuHomeElementl
Differential D8569

chore: allow graphene middleware when instantiating dagit
ClosedPublic
Actions

Authored by rexledesma on Jun 28 2021, 5:36 PM.

Details

Reviewers
dish
jordansanders
dgibson
Commits
R1:6151b971dd84: chore: allow graphene middleware when instantiating dagit
Summary

Allow middleware like https://dagster.phacility.com/D8568 when standing up Dagit.

Test Plan

bk

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rexledesma created this revision.Jun 28 2021, 5:36 PM
Harbormaster completed remote builds in B32743: Diff 40337.Jun 28 2021, 6:01 PM
rexledesma requested review of this revision.Jun 28 2021, 6:01 PM
dish accepted this revision.Jun 28 2021, 8:21 PM

Seems fine, but I don't really have any context on why this is being added. It would be nice to have more information in the summary.

This revision is now accepted and ready to land.Jun 28 2021, 8:21 PM
rexledesma edited the summary of this revision. (Show Details)Jun 28 2021, 8:25 PM
Closed by commit R1:6151b971dd84: chore: allow graphene middleware when instantiating dagit (authored by rexledesma). · Explain WhyJun 28 2021, 10:16 PM
This revision was automatically updated to reflect the committed changes.
rexledesma added a commit: R1:6151b971dd84: chore: allow graphene middleware when instantiating dagit.

Revision Contents
Changeset List

PathSize
python_modules/
dagit/
dagit/
2 lines

Diff 40375

View Options

python_modules/dagit/dagit/app.py

Loading...