Differential D8567

[dagit] Settings page
ClosedPublic
Actions

Authored by • dish on Jun 28 2021, 4:10 PM.

Details

Reviewers

• bengotow

Commits

R1:084503f62f9f: [dagit] Settings page

Summary

Restore the Settings page originally created for the earlier left navigation experiment. This gives us a place to:

Move the timezone selector, which occupies valuable left nav space in spite of being a one-time setting for users
Surface feature flags for enabling/disabling features without our needing to direct users to find /flags

Test Plan

Load dagit, verify that the settings cog renders and behaves correctly in the top nav. View Settings, verify that everything behaves correctly when clicked. View left nav, verify that scrolling is correct, inside and outside of Crag flag.

Diff Detail

Repository

R1 dagster

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• dish created this revision.Jun 28 2021, 4:10 PM

Screen Shot 2021-06-28 at 11.06.04 AM.png (1×2 px, 128 KB)

User settings

Harbormaster completed remote builds in B32735: Diff 40324.Jun 28 2021, 4:22 PM

Harbormaster completed remote builds in B32736: Diff 40325.

• dish requested review of this revision.Jun 28 2021, 4:23 PM

I think it'd be nice to go ahead and rip out /flags or have it redirect to this new page, seems like having both isn't super useful.

It doesn't really make sense given we only have two flags, but it'd be really nice to differentiate between "Advanced Options"-style flags (eg: debug logging), and "Upcoming Features"-style flags. The mode/pipeline one is sort of on a different tier than the debug logging. That said, also seems having a subheader for each one is a bit silly...

This revision is now accepted and ready to land.Jun 30 2021, 4:14 AM

Closed by commit R1:084503f62f9f: [dagit] Settings page (authored by • dish). · Explain WhyJun 30 2021, 1:25 PM

This revision was automatically updated to reflect the committed changes.

• dish added a commit: R1:084503f62f9f: [dagit] Settings page.