Page MenuHomeElementl

[dagit] Settings page
ClosedPublic

Authored by dish on Jun 28 2021, 4:10 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Feb 3, 4:26 AM
Unknown Object (File)
Sat, Jan 21, 2:40 PM
Unknown Object (File)
Jan 1 2023, 3:30 PM
Unknown Object (File)
Dec 31 2022, 5:32 AM
Unknown Object (File)
Dec 27 2022, 7:03 AM
Unknown Object (File)
Dec 20 2022, 8:37 PM
Unknown Object (File)
Dec 10 2022, 2:09 AM
Unknown Object (File)
Dec 1 2022, 9:57 PM
Subscribers
None

Details

Summary

Restore the Settings page originally created for the earlier left navigation experiment. This gives us a place to:

  • Move the timezone selector, which occupies valuable left nav space in spite of being a one-time setting for users
  • Surface feature flags for enabling/disabling features without our needing to direct users to find /flags
Test Plan

Load dagit, verify that the settings cog renders and behaves correctly in the top nav. View Settings, verify that everything behaves correctly when clicked. View left nav, verify that scrolling is correct, inside and outside of Crag flag.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I think it'd be nice to go ahead and rip out /flags or have it redirect to this new page, seems like having both isn't super useful.

It doesn't really make sense given we only have two flags, but it'd be really nice to differentiate between "Advanced Options"-style flags (eg: debug logging), and "Upcoming Features"-style flags. The mode/pipeline one is sort of on a different tier than the debug logging. That said, also seems having a subheader for each one is a bit silly...

This revision is now accepted and ready to land.Jun 30 2021, 4:14 AM
This revision was automatically updated to reflect the committed changes.