Page MenuHomeElementl

3/ update update_version script to upload new versioned content/images to s3
ClosedPublic

Authored by yuhan on Jun 28 2021, 8:41 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 17, 4:39 AM
Unknown Object (File)
Mon, May 15, 11:12 AM
Unknown Object (File)
Sat, May 13, 7:46 PM
Unknown Object (File)
Fri, May 12, 8:57 AM
Unknown Object (File)
Thu, May 11, 4:45 PM
Unknown Object (File)
May 8 2023, 2:47 PM
Unknown Object (File)
Mar 5 2023, 6:01 AM
Unknown Object (File)
Feb 15 2023, 1:27 AM
Subscribers
None

Details

Summary

depends on D8558

  1. create versioned content /tmp/versioned_content/<version_value> and upload it to s3/versioned_content/<version_value>
  2. create versioned images /tmp/versioned_images/<value_value> and upload it to s3/versioned_images/<version_value>
  3. prettify versions and versioned_navigation json so git can better capture the changes (trying to avoid the merge conflict caused by master and release branch out of sync)
Test Plan

ran python update_version.py --version 0.11.foo locally, got versioned_content and versioned_images show up in the s3 bucket.

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jordansanders added inline comments.
docs/next/.versioned_content/_versions.json
1–19

Smart! This should save us so many headaches.

docs/update_version.py
1–2

https://click.palletsprojects.com/en/8.0.x/utils/#printing-to-stdout

click.echo if we want to avoid disabling this pylint

This revision is now accepted and ready to land.Jun 29 2021, 3:07 PM

print -> click.echo
update remove_version.py too