Page MenuHomePhabricator

Use __slots__ for PipelineRun
ClosedPublic

Authored by max on Wed, Aug 21, 3:14 PM.

Details

Reviewers
alangenfeld
Group Reviewers
Restricted Project
Commits
R1:71dd902df311: Use __slots__ for PipelineRun
Test Plan

Unit

Diff Detail

Repository
R1 dagster
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

max created this revision.Wed, Aug 21, 3:14 PM

whats the point of slots? just speculative memory optimization?

python_modules/dagster/dagster/core/storage/runs.py
370

why do we double prefix this?

alangenfeld accepted this revision.Wed, Aug 21, 3:20 PM

no real cost to this though so whatevs

This revision is now accepted and ready to land.Wed, Aug 21, 3:20 PM
max added a subscriber: schrockn.Wed, Aug 21, 4:17 PM

Yeah, at @schrockn's request

max updated this revision to Diff 3891.Wed, Aug 21, 4:18 PM

Rebase

This revision was landed with ongoing or failed builds.Wed, Aug 21, 4:25 PM
This revision was automatically updated to reflect the committed changes.