Page MenuHomeElementl
Differential D8513

[dagit] Tidy up some JS
ClosedPublic
Actions

Authored by • dish on Jun 24 2021, 6:31 PM.
Tags
None
Referenced Files
F2776760: D8513.id40527.diff
Wed, Feb 8, 6:25 AM
Unknown Object (File)
Tue, Feb 7, 12:41 AM
Unknown Object (File)
Sat, Feb 4, 8:34 PM
Unknown Object (File)
Thu, Jan 19, 1:01 AM
Unknown Object (File)
Sat, Jan 14, 11:17 AM
Unknown Object (File)
Dec 12 2022, 1:25 PM
Unknown Object (File)
Nov 18 2022, 12:12 AM
Unknown Object (File)
Nov 18 2022, 12:12 AM
View All 36 Files
Subscribers
None

Details

Reviewers
• bengotow
Commits
R1:76796c902965: [dagit] Tidy up some JS
Summary

Clean up some todos for myself, and run find-dead-code to remove some straggling exports.

Test Plan

Buildkite

Diff Detail

Repository
R1 dagster
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• dish created this revision.Jun 24 2021, 6:31 PM
Harbormaster completed remote builds in B32582: Diff 40143.Jun 24 2021, 6:40 PM
• dish requested review of this revision.Jun 24 2021, 6:40 PM
• bengotow accepted this revision.Jun 30 2021, 4:19 AM
• bengotow added inline comments.
js_modules/dagit/packages/core/src/app/AppCache.tsx
45

🕺

This revision is now accepted and ready to land.Jun 30 2021, 4:19 AM
Closed by commit R1:76796c902965: [dagit] Tidy up some JS (authored by • dish). · Explain WhyJun 30 2021, 1:28 PM
This revision was automatically updated to reflect the committed changes.
• dish added a commit: R1:76796c902965: [dagit] Tidy up some JS.

Revision Contents
Changeset List

PathSize
js_modules/
dagit/
packages/
core/
2 lines
src/
app/
3 lines
6 lines
partitions/
2 lines
runs/
5 lines
2 lines

Diff 40527

View Options

js_modules/dagit/packages/core/package.json

Loading...
View Options

js_modules/dagit/packages/core/src/app/AppCache.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/app/AppProvider.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/partitions/RunMatrixUtils.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/runs/LogsProvider.tsx

Loading...
View Options

js_modules/dagit/packages/core/src/runs/MetadataEntry.tsx

Loading...